tkalkirill commented on code in PR #861:
URL: https://github.com/apache/ignite-3/pull/861#discussion_r893483021


##########
modules/configuration/src/test/java/org/apache/ignite/internal/configuration/testframework/ConfigurationExtensionTest.java:
##########
@@ -169,4 +174,19 @@ void testParamConfigurationStorageRevisionListenerHolder(
 
         assertTrue(revisions.get(0) < revisions.get(1), revisions::toString);
     }
+
+    /** Test UUID generation in mocks. */
+    @Test
+    public void testInjectInternalId(
+            @InjectConfiguration(
+                    name = "test",
+                    polymorphicExtensions = {
+                            SortedIndexConfigurationSchema.class,
+                            UnknownDataStorageConfigurationSchema.class
+                    },
+                    internalExtensions = { 
ExtendedTableConfigurationSchema.class }
+            ) TableConfiguration tableCfg

Review Comment:
   Let's, by analogy with 
**org.apache.ignite.internal.configuration.schema.ExtendedTableConfigurationSchema**,
 create an inheritor from 
**org.apache.ignite.internal.configuration.sample.DiscoveryConfigurationSchema**
 with the field
   ```
       @InternalId
       public UUID id;
   ```
   



##########
modules/configuration/pom.xml:
##########
@@ -70,6 +70,11 @@
         </dependency>
 
         <!-- Test dependencies -->
+        <dependency>
+            <groupId>org.apache.ignite</groupId>
+            <artifactId>ignite-extended-api</artifactId>

Review Comment:
   What is this dependency for?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to