rpuch commented on code in PR #908:
URL: https://github.com/apache/ignite-3/pull/908#discussion_r910684007
##########
modules/raft/src/integrationTest/java/org/apache/ignite/internal/raft/ItLozaTest.java:
##########
@@ -66,7 +67,7 @@ public class ItLozaTest {
*/
private RaftGroupService startClient(String groupId, ClusterNode node,
Loza loza) throws Exception {
return loza.prepareRaftGroup(groupId,
- List.of(node), () -> mock(RaftGroupListener.class)
+ List.of(node), () -> mock(RaftGroupListener.class),
RaftGroupOptions.defaults()
Review Comment:
I tried to import it statically in tests (to make it less verbose), but I
did not import it statically in production code (to make it more visible). Now,
I made all the code to conform to this rule.
WDYT?
##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/server/impl/JraftServerImpl.java:
##########
@@ -339,13 +351,20 @@ public synchronized boolean startRaftGroup(String
groupId, @NotNull RaftGroupEve
throw new IgniteInternalException(e);
}
- nodeOptions.setRaftMetaUri(serverDataPath.resolve("meta").toString());
+ if (!groupOptions.volatileStores()) {
+
nodeOptions.setRaftMetaUri(serverDataPath.resolve("meta").toString());
+ }
nodeOptions.setSnapshotUri(serverDataPath.resolve("snapshot").toString());
nodeOptions.setFsm(new DelegatingStateMachine(lsnr));
nodeOptions.setRaftGrpEvtsLsnr(evLsnr);
+ if (groupOptions.volatileStores()) {
+ // override to volatile stores
Review Comment:
Sure, removed it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
