rpuch commented on code in PR #908:
URL: https://github.com/apache/ignite-3/pull/908#discussion_r910686422
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -500,6 +502,10 @@ private void
updateAssignmentInternal(ConfigurationNotificationEvent<byte[]> ass
CompletableFuture.allOf(futures).join();
}
+ private RaftGroupOptions groupOptionsForInternalTable(InternalTable
internalTbl) {
+ return new RaftGroupOptions(internalTbl.storage().isVolatile());
Review Comment:
Yes, this makes sense, thanks for the suggestion. Added a static factory
(with a slightly different name).
As for the possibility to have other group-specific options: it's unclear,
for now we only have one. If there are more, we'll be able to change the
approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
