ptupitsyn commented on code in PR #916:
URL: https://github.com/apache/ignite-3/pull/916#discussion_r914732606
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/type/IgniteTypeFactory.java:
##########
@@ -163,30 +161,72 @@ public Type getJavaClass(RelDataType type) {
}
/**
- * Gets ColumnType type for given class.
+ * Gets ColumnType type for RelDataType.
*
* @param relType Rel type.
* @return ColumnType type or null.
*/
- public ColumnType columnType(RelDataType relType) {
- assert relType != null;
+ public static ColumnType relDataTypeToColumnType(RelDataType relType) {
+ assert relType instanceof BasicSqlType
Review Comment:
Let's add TODOs with ticket links in all places where "not supported"
exception is thrown.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
