korlov42 commented on code in PR #916:
URL: https://github.com/apache/ignite-3/pull/916#discussion_r915486969
##########
modules/api/src/main/java/org/apache/ignite/schema/definition/ColumnType.java:
##########
@@ -203,14 +203,14 @@ public static TemporalColumnType time(int precision) {
}
/**
- * Returns timezone-free datetime encoded as (date, time) with the default
time precision of 6 (microseconds).
+ * Returns timezone-free datetime encoded as (date, time) with the default
time precision of 0 (seconds).
*
* @return Native type.
- * @see TemporalColumnType#DEFAULT_PRECISION
+ * @see TemporalColumnType#DEFAULT_TIME_PRECISION
* @see #datetime(int)
*/
public static TemporalColumnType datetime() {
- return new TemporalColumnType(ColumnTypeSpec.DATETIME,
TemporalColumnType.DEFAULT_PRECISION);
+ return new TemporalColumnType(ColumnTypeSpec.DATETIME,
TemporalColumnType.DEFAULT_TIME_PRECISION);
Review Comment:
I believe this here should be TIMESTAMP_PRECISION, since DATETIME
represented by a SQL TIMESTAMP type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
