alievmirza commented on code in PR #937:
URL: https://github.com/apache/ignite-3/pull/937#discussion_r920906065


##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/Loza.java:
##########
@@ -253,106 +262,57 @@ public void startRaftGroupNode(
         try {
             List<Peer> peers = nodes.stream().map(n -> new 
Peer(n.address())).collect(Collectors.toList());
 
-            String locNodeName = 
clusterNetSvc.topologyService().localMember().name();
+            LOG.info("Start new raft node for group={} with initial peers={}", 
grpId, peers);
 
-            if (deltaNodes.stream().anyMatch(n -> 
locNodeName.equals(n.name()))) {
-                LOG.info("Start new raft node for group={} with initial 
peers={}", grpId, peers);
+            if (!raftServer.startRaftGroup(grpId, raftGrpEvtsLsnr, lsnr, 
peers, groupOptions)) {

Review Comment:
   something is wrong, you don't even use delta nodes 



##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/Loza.java:
##########
@@ -253,106 +262,57 @@ public void startRaftGroupNode(
         try {
             List<Peer> peers = nodes.stream().map(n -> new 
Peer(n.address())).collect(Collectors.toList());
 
-            String locNodeName = 
clusterNetSvc.topologyService().localMember().name();
+            LOG.info("Start new raft node for group={} with initial peers={}", 
grpId, peers);
 
-            if (deltaNodes.stream().anyMatch(n -> 
locNodeName.equals(n.name()))) {
-                LOG.info("Start new raft node for group={} with initial 
peers={}", grpId, peers);
+            if (!raftServer.startRaftGroup(grpId, raftGrpEvtsLsnr, lsnr, 
peers, groupOptions)) {

Review Comment:
   something is wrong, you don't even use deltaNodes 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to