ibessonov commented on code in PR #937:
URL: https://github.com/apache/ignite-3/pull/937#discussion_r926467989
##########
modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbTableStorage.java:
##########
@@ -268,16 +268,22 @@ public RocksDbMvPartitionStorage
getOrCreateMvPartition(int partitionId) throws
@Override
public RocksDbMvPartitionStorage getMvPartition(int partitionId) {
if (getPartition(partitionId) == null) {
- throw new NullPointerException("Partition doesn't exist");
+ return null;
}
- return new RocksDbMvPartitionStorage(partitionId, db,
partitionCf.handle());
+ return new RocksDbMvPartitionStorage(partitionId, db,
partitionCf.handle(), meta.columnFamily().handle());
}
@Override
Review Comment:
Same here, this will break codestyle because you removed empty line. Simple
comment would be better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
