tkalkirill commented on code in PR #920:
URL: https://github.com/apache/ignite-3/pull/920#discussion_r921136765
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/PersistentPageMemory.java:
##########
@@ -920,19 +935,21 @@ public int invalidate(int grpId, int partId) {
int tag = 0;
- for (Segment seg : segments) {
- seg.writeLock().lock();
+ for (Segment segment : segments) {
+ segment.writeLock().lock();
try {
- int newTag = seg.incrementPartGeneration(grpId, partId);
+ int newTag = segment.incrementPartGeneration(grpId,
partId);
if (tag == 0) {
tag = newTag;
}
assert tag == newTag;
+
+ segment.dirtyPartitions.remove(new GroupPartitionId(grpId,
partId));
Review Comment:
Discussed personally, no need to change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
