tkalkirill commented on code in PR #920:
URL: https://github.com/apache/ignite-3/pull/920#discussion_r921170910
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/CheckpointDirtyPages.java:
##########
@@ -113,29 +116,29 @@ public CheckpointDirtyPagesQueue toQueue() {
FullPageId endPageId = new FullPageId(pageId(partId + 1, (byte) 0, 0),
grpId);
for (int i = 0; i < dirtyPages.size(); i++) {
- List<FullPageId> pageIds = dirtyPages.get(i).getValue();
+ FullPageId[] pageIds = dirtyPages.get(i).dirtyPages.pageIds;
Review Comment:
There is a description for the method that says that we get a view of all
pages for a specific partition and group.
Added a method with one more method.
> Also, passing a DataRegion or PageMemory instance here would help you
avoiding unnecessary binary searches.
Removed constructor.
> Also, why exactly do we have a list of arrays instead of the Map, as in
the original constructor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
