tkalkirill commented on code in PR #947: URL: https://github.com/apache/ignite-3/pull/947#discussion_r928610749
########## modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/store/DeltaFilePageStoreIoFactory.java: ########## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.pagememory.persistence.store; + +/** + * Factory for creating {@link DeltaFilePageStoreIo}. + */ +@FunctionalInterface +public interface DeltaFilePageStoreIoFactory { Review Comment: We personally decided that I would delete it. ########## modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/store/CompleteCreationDeltaFilePageStoreIoCallback.java: ########## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.pagememory.persistence.store; + +import org.apache.ignite.lang.IgniteInternalCheckedException; + +/** + * Callback on completion of delta file page store creation. + */ +@FunctionalInterface +public interface CompleteCreationDeltaFilePageStoreIoCallback { + /** + * Calls when the delta file page store is finished creating. + * + * @param deltaFilePageStoreIo Delta file page store. + * @throws IgniteInternalCheckedException If failed. + */ + void onCompletionOfCreation(DeltaFilePageStoreIo deltaFilePageStoreIo) throws IgniteInternalCheckedException; Review Comment: We personally decided that I would delete it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
