tkalkirill commented on code in PR #947:
URL: https://github.com/apache/ignite-3/pull/947#discussion_r928622604
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/store/FilePageStoreFactory.java:
##########
@@ -52,45 +54,67 @@ public FilePageStoreFactory(FileIoFactory fileIoFactory,
int pageSize) {
/**
* Creates instance of {@link FilePageStore}.
*
- * <p>If the file exists, an attempt will be made to read its {@link
FilePageStoreHeader header} and create the {@link FilePageStore}.
+ * <p>Page stores are created based on their headers, for a file page
stores with no header, the latest version is generated for delta
+ * file page store files, headers must be present.
*
- * @param filePath File page store path.
- * @param headerBuffer Buffer for reading {@link FilePageStoreHeader
header} from {@code filePath}.
- * @return File page store.
+ * @param headerBuffer Buffer for reading headers.
+ * @param filePageStorePath File page store path.
Review Comment:
Fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
