tkalkirill commented on code in PR #995:
URL: https://github.com/apache/ignite-3/pull/995#discussion_r944364708
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/CheckpointListener.java:
##########
@@ -29,9 +31,10 @@ public interface CheckpointListener {
* <p>Holds checkpoint write lock.
*
* @param progress Progress of the current checkpoint.
+ * @param executor Executor for asynchronously executing the callback.
* @throws IgniteInternalCheckedException If failed.
*/
- default void onMarkCheckpointBegin(CheckpointProgress progress) throws
IgniteInternalCheckedException {
+ default void onMarkCheckpointBegin(CheckpointProgress progress, @Nullable
Executor executor) throws IgniteInternalCheckedException {
Review Comment:
It seems that if there is an executor, then the code will be asynchronous,
but this is not necessary and there may be less understanding of what is
happening.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
