tkalkirill commented on code in PR #995:
URL: https://github.com/apache/ignite-3/pull/995#discussion_r944372606
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/CheckpointWorkflow.java:
##########
@@ -140,21 +173,32 @@ public void stop() {
* @param startCheckpointTimestamp Checkpoint start timestamp.
* @param curr Current checkpoint event info.
* @param tracker Checkpoint metrics tracker.
+ * @param updateHeartbeat Update heartbeat callback.
+ * @param onReleaseWriteLock Callback on write lock release.
* @return Checkpoint collected info.
* @throws IgniteInternalCheckedException If failed.
*/
public Checkpoint markCheckpointBegin(
long startCheckpointTimestamp,
CheckpointProgressImpl curr,
- CheckpointMetricsTracker tracker
+ CheckpointMetricsTracker tracker,
+ Runnable updateHeartbeat,
+ Runnable onReleaseWriteLock
) throws IgniteInternalCheckedException {
List<CheckpointListener> listeners =
collectCheckpointListeners(dataRegions);
checkpointReadWriteLock.readLock();
+ AwaitTasksCompletionExecutor executor = callbackListenerThreadPool ==
null
+ ? null : new
AwaitTasksCompletionExecutor(callbackListenerThreadPool, updateHeartbeat);
Review Comment:
You're right and in general you need to update more often
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/CheckpointWorkflow.java:
##########
@@ -140,21 +173,32 @@ public void stop() {
* @param startCheckpointTimestamp Checkpoint start timestamp.
* @param curr Current checkpoint event info.
* @param tracker Checkpoint metrics tracker.
+ * @param updateHeartbeat Update heartbeat callback.
+ * @param onReleaseWriteLock Callback on write lock release.
* @return Checkpoint collected info.
* @throws IgniteInternalCheckedException If failed.
*/
public Checkpoint markCheckpointBegin(
long startCheckpointTimestamp,
CheckpointProgressImpl curr,
- CheckpointMetricsTracker tracker
+ CheckpointMetricsTracker tracker,
+ Runnable updateHeartbeat,
+ Runnable onReleaseWriteLock
) throws IgniteInternalCheckedException {
List<CheckpointListener> listeners =
collectCheckpointListeners(dataRegions);
checkpointReadWriteLock.readLock();
+ AwaitTasksCompletionExecutor executor = callbackListenerThreadPool ==
null
+ ? null : new
AwaitTasksCompletionExecutor(callbackListenerThreadPool, updateHeartbeat);
Review Comment:
You're right and in general i need to update more often
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
