ibessonov commented on code in PR #1003:
URL: https://github.com/apache/ignite-3/pull/1003#discussion_r945625435
##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/mv/VersionChain.java:
##########
@@ -49,33 +39,22 @@ public class VersionChain extends VersionChainLink
implements Storable {
private final long headLink;
/**
- * Link to the pre-latest version ({@link RowVersion#NULL_LINK} if there
is just one version).
+ * Link to the pre-latest version ({@link RowVersion#isNullLink(long)} is
{@code true} if there is just one version).
*/
private final long nextLink;
/**
* Constructs a VersionChain without a transaction ID.
*/
- public static VersionChain withoutTxId(int partitionId, long link, long
headLink, long nextLink) {
- return new VersionChain(partitionId, link, null, headLink, nextLink);
+ public static VersionChain withoutTxId(RowId rowId, long headLink, long
nextLink) {
Review Comment:
I just left it here, should I remove it?
I don't mind passing "null" explicitly tbh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
