ibessonov commented on code in PR #1003:
URL: https://github.com/apache/ignite-3/pull/1003#discussion_r945626512
##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/mv/AbstractPageMemoryMvPartitionStorage.java:
##########
@@ -50,51 +49,44 @@ public abstract class AbstractPageMemoryMvPartitionStorage
implements MvPartitio
private static final Predicate<BinaryRow> MATCH_ALL = row -> true;
private static final Predicate<Timestamp> ALWAYS_LOAD_VALUE = timestamp ->
true;
- private static final Predicate<Timestamp> NEVER_LOAD_VALUE = timestamp ->
false;
- private static final Predicate<Timestamp> LOAD_VALUE_WHEN_UNCOMMITTED =
RowVersion::isUncommitted;
- private final int partId;
+ private final int partitionId;
private final int groupId;
- private final VersionChainFreeList versionChainFreeList;
private final VersionChainTree versionChainTree;
- private final VersionChainDataPageReader versionChainDataPageReader;
private final RowVersionFreeList rowVersionFreeList;
private final DataPageReader rowVersionDataPageReader;
- private final ThreadLocal<ReadRowVersion> readRowVersionCache =
ThreadLocal.withInitial(ReadRowVersion::new);
- private final ThreadLocal<ScanVersionChainByTimestamp>
scanVersionChainByTimestampCache = ThreadLocal.withInitial(
- ScanVersionChainByTimestamp::new
- );
+ private final ThreadLocal<ReadRowVersion> readRowVersionCache;
Review Comment:
No, I'm not sure about it. Allocation is fast enough. Should I get rid of
these?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
