ibessonov commented on code in PR #1016:
URL: https://github.com/apache/ignite-3/pull/1016#discussion_r956003401
##########
modules/core/src/main/java/org/apache/ignite/internal/util/ByteUtils.java:
##########
@@ -123,12 +123,12 @@ public static byte[] toBytes(Object obj) {
* @param bytes Byte array.
* @return Object.
*/
- public static Object fromBytes(byte[] bytes) {
+ public static <T> T fromBytes(byte[] bytes) {
try (
var bis = new ByteArrayInputStream(bytes);
var in = new ObjectInputStream(bis)
) {
- return in.readObject();
+ return (T) in.readObject();
Review Comment:
I'm against such code, but for other reasons.
Technically, both approaches are absolutely the same here. This method will
return Object without cast, because no type information is available to it.
It's all just sugar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
