SammyVimes commented on code in PR #1016:
URL: https://github.com/apache/ignite-3/pull/1016#discussion_r957293182
##########
modules/metastorage-client/src/main/java/org/apache/ignite/internal/metastorage/client/SimpleCondition.java:
##########
@@ -77,6 +77,8 @@ public long revision() {
* @throws IllegalStateException In the case when the condition is
already defined.
*/
public SimpleCondition eq(long rev) {
+ assert rev > 0 : "Revision must be positive.";
Review Comment:
1) It's basically the same check as on the metastorage's server side, see
`RevisionCondition`'s constructor.
2) What do you mean? Something like `Requires#requireNonNull`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
