SammyVimes commented on code in PR #1102:
URL: https://github.com/apache/ignite-3/pull/1102#discussion_r974468136
##########
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/MvPartitionStorage.java:
##########
@@ -106,12 +106,12 @@ private static HybridTimestamp convertTimestamp(Timestamp
timestamp) {
*
* @param rowId Row id.
* @param txId Transaction id.
- * @return Binary row that corresponds to the key or {@code null} if value
is not found.
+ * @return Read result that corresponds to the key or {@code null} if
value is not found.
* @throws TxIdMismatchException If there's another pending update
associated with different transaction id.
* @throws StorageException If failed to read data from the storage.
*/
@Nullable
- BinaryRow read(RowId rowId, UUID txId) throws TxIdMismatchException,
StorageException;
+ ReadResult read(RowId rowId, UUID txId) throws TxIdMismatchException,
StorageException;
Review Comment:
Right
##########
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/MvPartitionStorage.java:
##########
@@ -142,28 +151,30 @@ default BinaryRow read(RowId rowId, Timestamp timestamp)
throws StorageException
* @return Row id.
* @throws StorageException If failed to write data into the storage.
*
- * @deprecated Generates different ids for each replica. {@link
#addWrite(RowId, BinaryRow, UUID)} with explicit replicated id must be
- * used instead.
+ * @deprecated Generates different ids for each replica. {@link
#addWrite(RowId, BinaryRow, UUID, UUID, int)} with explicit replicated
+ * id must be used instead.
*/
@Deprecated
RowId insert(BinaryRow binaryRow, UUID txId) throws StorageException;
/**
- * Creates (or replaces) an uncommitted (aka pending) version, assigned to
the given transaction id.
- * In details:
- * - if there is no uncommitted version, a new uncommitted version is added
- * - if there is an uncommitted version belonging to the same transaction,
it gets replaced by the given version
- * - if there is an uncommitted version belonging to a different
transaction, {@link TxIdMismatchException} is thrown
+ * Creates (or replaces) an uncommitted (aka pending) version, assigned to
the given transaction id. In details: - if there is no
Review Comment:
How did this happen Oo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
