ibessonov commented on code in PR #1102:
URL: https://github.com/apache/ignite-3/pull/1102#discussion_r974942902
##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/mv/AbstractPageMemoryMvPartitionStorage.java:
##########
@@ -213,7 +218,11 @@ private PageMemoryHashIndexStorage
createOrRestoreHashIndex(IndexMeta indexMeta)
/** {@inheritDoc} */
@Override
- public @Nullable BinaryRow read(RowId rowId, HybridTimestamp timestamp)
throws StorageException {
+ public @Nullable ReadResult read(RowId rowId, HybridTimestamp timestamp)
throws StorageException {
Review Comment:
> Basically ReadResult can be null, but binary row inside it can't be null.
This is a faulty logic. You should write such tests. Imagine if you already
have a value and you remove it in transaction. This means returning a write
intent with null value and non-null timestamp. Is that correct? I think it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
