sashapolo commented on code in PR #1213:
URL: https://github.com/apache/ignite-3/pull/1213#discussion_r997032097
##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/index/sorted/io/SortedIndexTreeIo.java:
##########
@@ -48,17 +55,47 @@
* </ul>
*/
public interface SortedIndexTreeIo {
- /** Offset of the index column link (6 bytes). */
- int INDEX_COLUMNS_LINK_OFFSET = 0;
+ /** Item size without index columns in bytes. */
+ int ITEM_SIZE_WITHOUT_COLUMNS = Short.SIZE // Inlined index columns size.
+ + PARTITIONLESS_LINK_SIZE_BYTES // Index columns link.
+ + 2 * Long.BYTES; // Row ID.
- /** Offset of rowId's most significant bits, 8 bytes. */
- int ROW_ID_MSB_OFFSET = INDEX_COLUMNS_LINK_OFFSET +
PARTITIONLESS_LINK_SIZE_BYTES;
+ /** Index columns are not fully inlined, the index column size is {@link
#indexColumnsInlineSize()}. */
Review Comment:
I don't understand, how is this constant expected to be used? Maybe it
should be called `NOT_FULLY_INLINED_FLAG`? And why is it a `short`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
