tkalkirill commented on code in PR #1213:
URL: https://github.com/apache/ignite-3/pull/1213#discussion_r997093749
##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/index/sorted/io/SortedIndexTreeIo.java:
##########
@@ -117,39 +166,48 @@ default int compare(
int idx,
SortedIndexRowKey rowKey
) throws IgniteInternalCheckedException {
- int off = offset(idx);
+ final int off = offset(idx);
Review Comment:
Cause I shot myself in the foot with no `final`.
##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/index/sorted/io/SortedIndexTreeIo.java:
##########
@@ -164,23 +222,42 @@ default int compare(
*/
default SortedIndexRow getRow(DataPageReader dataPageReader, int
partitionId, long pageAddr, int idx)
throws IgniteInternalCheckedException {
- int off = offset(idx);
+ final int off = offset(idx);
Review Comment:
Cause I shot myself in the foot with no `final`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
