sashapolo commented on code in PR #1213:
URL: https://github.com/apache/ignite-3/pull/1213#discussion_r997161211
##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/index/sorted/io/SortedIndexTreeIo.java:
##########
@@ -76,25 +113,37 @@ default void store(long dstPageAddr, int dstIdx,
BplusIo<SortedIndexRowKey> srcI
int dstOffset = offset(dstIdx);
int srcOffset = offset(srcIdx);
- PageUtils.copyMemory(srcPageAddr, srcOffset, dstPageAddr, dstOffset,
SIZE_IN_BYTES);
+ PageUtils.copyMemory(srcPageAddr, srcOffset, dstPageAddr, dstOffset,
getItemSize());
}
/**
* Stores a sorted index row in the page.
*
* @see BplusIo#storeByOffset(long, int, Object)
*/
- default void storeByOffset(long pageAddr, int off, SortedIndexRowKey
rowKey) {
+ default void storeByOffset(long pageAddr, final int off, SortedIndexRowKey
rowKey) {
Review Comment:
why not every parameter is `final` then? Shooting in the foot can happen at
any time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
