tkalkirill commented on code in PR #1239:
URL: https://github.com/apache/ignite-3/pull/1239#discussion_r1005389731
##########
modules/core/src/main/java/org/apache/ignite/internal/future/OrderingFuture.java:
##########
@@ -559,4 +569,16 @@ private enum Phase {
*/
COMPLETED
}
+
+ private static class NotificationContext {
Review Comment:
Lack of documentation for the class and method
##########
modules/core/src/main/java/org/apache/ignite/internal/future/OrderingFuture.java:
##########
@@ -529,12 +537,14 @@ public void notifyHeadToTail(T result, Throwable
exception, ListNode<T> lastNoti
stack.addFirst(node);
}
+ NotificationContext context = new NotificationContext();
Review Comment:
Why not just store the exception in a local variable and just pass it to
`org.apache.ignite.internal.future.OrderingFuture.DependentAction#onCompletion`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
