rpuch commented on code in PR #1239:
URL: https://github.com/apache/ignite-3/pull/1239#discussion_r1005663286
##########
modules/core/src/main/java/org/apache/ignite/internal/future/OrderingFuture.java:
##########
@@ -529,12 +537,14 @@ public void notifyHeadToTail(T result, Throwable
exception, ListNode<T> lastNoti
stack.addFirst(node);
}
+ NotificationContext context = new NotificationContext();
Review Comment:
We need to create the exception lazily because not all dependents need it,
so it might happen that no dependent needs the exception. Context allows us to
implement that lazy creation logic. Please note that it is much more expensive
to create an exception that a context object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
