ademakov commented on code in PR #1272: URL: https://github.com/apache/ignite-3/pull/1272#discussion_r1008124377
########## modules/platforms/cpp/ignite/network/network.cpp: ########## @@ -23,15 +23,20 @@ #ifdef _WIN32 # include "detail/win/win_async_client_pool.h" -#else // Other. Assume Linux +#elif __linux__ Review Comment: This is non-standard preprocessor usage. `#elif` should go after `#if` not `#ifdef`. So you have to replace `#ifdef XXX` with `#if defined(XXX)`/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
