SammyVimes commented on code in PR #1272: URL: https://github.com/apache/ignite-3/pull/1272#discussion_r1008334226
########## modules/platforms/cpp/ignite/common/config.h: ########## @@ -51,10 +51,12 @@ #endif /** - * Macro IGNITE_SWITCH_WIN_OTHER that uses first option on Windows and second on any other OS. + * Macro IGNITE_OS_SWITCH that uses first option on Windows, second on Linux and third on MacOS. Review Comment: Probably, yes, but I don't know what other operating systems are we going to support, this looks like an exhaustive list (at least for now). z/OS probably? Frankly, I don't have enough experience with C++ to come up with a better idea than this macro -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
