sashapolo commented on code in PR #1331:
URL: https://github.com/apache/ignite-3/pull/1331#discussion_r1020284567
##########
modules/page-memory/src/test/java/org/apache/ignite/internal/pagememory/persistence/PartitionMetaTest.java:
##########
@@ -41,15 +44,45 @@ void testLastAppliedIndex() {
assertEquals(0, meta.lastAppliedIndex());
- assertDoesNotThrow(() -> meta.lastAppliedIndex(null, 100));
+ assertDoesNotThrow(() -> meta.lastApplied(null, 100, 10));
assertEquals(100, meta.lastAppliedIndex());
- assertDoesNotThrow(() -> meta.lastAppliedIndex(UUID.randomUUID(),
500));
+ assertDoesNotThrow(() -> meta.lastApplied(UUID.randomUUID(), 500, 50));
assertEquals(500, meta.lastAppliedIndex());
}
+ @Test
+ void testLastAppliedTerm() {
+ PartitionMeta meta = new PartitionMeta();
+
+ assertEquals(0, meta.lastAppliedTerm());
+
+ assertDoesNotThrow(() -> meta.lastApplied(null, 100, 10));
Review Comment:
Can we change the other tests instead? This looks quite strange to me
##########
modules/page-memory/src/test/java/org/apache/ignite/internal/pagememory/persistence/PartitionMetaTest.java:
##########
@@ -41,15 +44,45 @@ void testLastAppliedIndex() {
assertEquals(0, meta.lastAppliedIndex());
- assertDoesNotThrow(() -> meta.lastAppliedIndex(null, 100));
+ assertDoesNotThrow(() -> meta.lastApplied(null, 100, 10));
assertEquals(100, meta.lastAppliedIndex());
- assertDoesNotThrow(() -> meta.lastAppliedIndex(UUID.randomUUID(),
500));
+ assertDoesNotThrow(() -> meta.lastApplied(UUID.randomUUID(), 500, 50));
assertEquals(500, meta.lastAppliedIndex());
}
+ @Test
+ void testLastAppliedTerm() {
+ PartitionMeta meta = new PartitionMeta();
+
+ assertEquals(0, meta.lastAppliedTerm());
+
+ assertDoesNotThrow(() -> meta.lastApplied(null, 100, 10));
Review Comment:
Can we change the other test instead? This looks quite strange to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
