sashapolo commented on code in PR #1331:
URL: https://github.com/apache/ignite-3/pull/1331#discussion_r1020286865


##########
modules/table/src/test/java/org/apache/ignite/internal/table/distributed/raft/snapshot/outgoing/OutgoingSnapshotMvDataStreamingTest.java:
##########
@@ -281,6 +280,43 @@ void sendsOutOfOrderRowsWithHighestPriority() {
         assertThat(response.rows().get(1).rowId(), is(rowId1.uuid()));
     }
 
+    @Test
+    void doesNotEnqueueMissingRows() {
+        
when(mvPartitionStorage.scanVersions(rowIdOutOfOrder)).thenReturn(Cursor.fromIterator(emptyIterator()));

Review Comment:
   We used to, but you will have to make `EMPTY_CURSOR` public, which I don't 
like, so I decided to move it here (like `Collections.emptyList()`. Maybe we 
can add a method to `Cursor` which delegates to `CursorUtils` but I don't know 
if it's a good idea



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to