rpuch commented on code in PR #1331:
URL: https://github.com/apache/ignite-3/pull/1331#discussion_r1021331930
##########
modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbMvPartitionStorage.java:
##########
@@ -178,11 +180,29 @@ public class RocksDbMvPartitionStorage implements
MvPartitionStorage {
/** Key to store applied index value in meta. */
private final byte[] lastAppliedIndexKey;
+ /** Key to store applied term value in meta. */
+ private final byte[] lastAppliedTermKey;
Review Comment:
We could, but should we? This makes a code arguably more difficult to
understand.
In `TxStateRocksDbStorage` this is what I did: I store them under the same
key, but there we don't use a separate meta CF, so we only have 1 key that can
be used in a 'not too ugly way'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
