rpuch commented on code in PR #1331:
URL: https://github.com/apache/ignite-3/pull/1331#discussion_r1021339972


##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/snapshot/incoming/IncomingSnapshotReader.java:
##########
@@ -66,7 +66,7 @@ public void shutdown() {
 
     @Override
     public String getPath() {
-        throw new UnsupportedOperationException("No path for the rebalance 
snapshot");
+        return "";

Review Comment:
   `FSMCallerImpl:672` (in `doSnapshotLoad()`):
   
   ```
   if (!this.fsm.onSnapshotLoad(reader)) {
   ```
   
   Which, in turn, calls `getPath()`, the result of which is later ignored by 
our `PartitionListener#onSnapshotLoad()`. But if an exception is thrown, it 
impedes the snapshot load process.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to