sashapolo commented on code in PR #1397:
URL: https://github.com/apache/ignite-3/pull/1397#discussion_r1043044850
##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/server/RaftServer.java:
##########
@@ -43,59 +44,65 @@ public interface RaftServer extends IgniteComponent {
* Starts a raft group bound to this cluster node.
*
* @param groupId Group id.
- * @param lsnr The listener.
- * @param peers Peers configuration.
+ * @param configuration Raft peers configuration.
+ * @param lsnr Listener for state machine events.
* @param groupOptions Options to apply to the group.
* @return {@code True} if a group was successfully started, {@code False}
when the group with given name is already exists.
*/
boolean startRaftGroup(
- ReplicationGroupId groupId,
+ RaftGroupId groupId,
+ PeersAndLearners configuration,
RaftGroupListener lsnr,
- List<Peer> peers,
RaftGroupOptions groupOptions
);
/**
* Starts a raft group bound to this cluster node.
*
* @param groupId Group id.
+ * @param configuration Raft peers configuration.
* @param evLsnr Listener for group membership and other events.
* @param lsnr Listener for state machine events.
- * @param peers Peers configuration.
- * @param learners Learners configuration.
* @param groupOptions Options to apply to the group.
* @return {@code True} if a group was successfully started, {@code False}
when the group with given name is already exists.
*/
boolean startRaftGroup(
- ReplicationGroupId groupId,
+ RaftGroupId groupId,
+ PeersAndLearners configuration,
RaftGroupEventsListener evLsnr,
RaftGroupListener lsnr,
- List<Peer> peers,
- List<Peer> learners,
RaftGroupOptions groupOptions
);
/**
- * Synchronously stops a raft group if any.
+ * Stops a given local Raft node if it exists.
Review Comment:
I think it can be implied, since this method does not return a
CompletableFuture
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
