sashapolo commented on code in PR #1397:
URL: https://github.com/apache/ignite-3/pull/1397#discussion_r1043097831
##########
modules/raft-api/src/main/java/org/apache/ignite/internal/raft/RaftManager.java:
##########
@@ -17,75 +17,83 @@
package org.apache.ignite.internal.raft;
-import java.util.Collection;
import java.util.concurrent.CompletableFuture;
import java.util.function.Supplier;
import org.apache.ignite.internal.manager.IgniteComponent;
import org.apache.ignite.internal.raft.service.RaftGroupListener;
import org.apache.ignite.internal.raft.service.RaftGroupService;
import org.apache.ignite.internal.replicator.ReplicationGroupId;
import org.apache.ignite.lang.NodeStoppingException;
+import org.jetbrains.annotations.Nullable;
/**
* Raft manager.
*/
public interface RaftManager extends IgniteComponent {
/**
- * Creates a raft group service providing operations on a raft group. If
{@code nodes} contains the current node, then raft group starts
- * on the current node.
+ * Creates a raft group service providing operations on a raft group.
*
* @param groupId Raft group id.
- * @param peerConsistentIds Consistent IDs of Raft peers.
+ * @param serverPeer Local peer that will host the Raft node. If {@code
null} - no nodes will be started, but only the Raft client.
+ * @param configuration Peers and Learners of the Raft group.
* @param lsnrSupplier Raft group listener supplier.
* @return Future representing pending completion of the operation.
* @throws NodeStoppingException If node stopping intention was detected.
*/
CompletableFuture<RaftGroupService> prepareRaftGroup(
ReplicationGroupId groupId,
- Collection<String> peerConsistentIds,
+ @Nullable Peer serverPeer,
+ PeersAndLearners configuration,
Review Comment:
I can see that JRaft also has a class called `Configuration` which only
contains peers and learners, so I think it shouldn't cause confusion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
