sashapolo commented on code in PR #1518:
URL: https://github.com/apache/ignite-3/pull/1518#discussion_r1069123280
##########
modules/metastorage/src/test/java/org/apache/ignite/internal/metastorage/watch/WatchAggregatorTest.java:
##########
@@ -274,8 +274,8 @@ private Entry entry(String key, String val, long revision,
long updateCntr) {
return new Entry() {
/** {@inheritDoc} */
@Override
- public @NotNull ByteArray key() {
- return new ByteArray(key);
+ public @NotNull byte[] key() {
Review Comment:
This class will be removed altogether in my next PR, so I don't think it's
necessary
##########
modules/runner/src/main/java/org/apache/ignite/internal/configuration/storage/DistributedConfigurationStorage.java:
##########
@@ -160,11 +163,11 @@ public void close() {
// Meta Storage should not return nulls as values
assert value != null;
- if (key.equals(MASTER_KEY)) {
+ if (Arrays.equals(key, MASTER_KEY.bytes())) {
continue;
}
- String dataKey =
key.toString().substring(DISTRIBUTED_PREFIX.length());
+ String dataKey = new String(key,
StandardCharsets.UTF_8).substring(DISTRIBUTED_PREFIX.length());
Review Comment:
sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
