sashapolo commented on code in PR #1518:
URL: https://github.com/apache/ignite-3/pull/1518#discussion_r1069126156
##########
modules/metastorage-api/src/main/java/org/apache/ignite/internal/metastorage/Entry.java:
##########
@@ -37,7 +35,7 @@ public interface Entry {
*
* @return The key.
*/
- @NotNull ByteArray key();
+ byte[] key();
Review Comment:
`ByteArray` doesn't make much sense, I think it needs to be removed
altogether. First, its just unnecessary wrapping and object creation (you can
compare arrays without it). Secondly, it makes an incorrect assumption that
arrays are compared using signed comparison, however we use unsigned comparison
in all storages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
