Vladsz83 commented on PR #10485: URL: https://github.com/apache/ignite/pull/10485#issuecomment-1396907110
> We don't need to copy code from existing to those new classes. Please, revert removal of existing JMX class and keep required methods in it. Done. I keep CacheClusterMetricsMXBeanImpl. But I think we violate S principle of SOLID. CacheStatisticsMXBean and CacheMXBean should be split and created separately on demand. The old beans implements the both interfaces. However, we pass JCache spec tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
