Vladsz83 commented on code in PR #10485:
URL: https://github.com/apache/ignite/pull/10485#discussion_r1083835143
##########
modules/clients/src/test/java/org/apache/ignite/internal/processors/rest/RestMemcacheProtocolSelfTest.java:
##########
@@ -185,8 +185,8 @@ public void testReplace() throws Exception {
*/
@Test
public void testMetrics() throws Exception {
- grid().cache(DEFAULT_CACHE_NAME).localMxBean().clear();
- grid().cache(CACHE_NAME).localMxBean().clear();
+ grid().cache(DEFAULT_CACHE_NAME).clearStatistics();
Review Comment:
> Why do we need new method `clearStatistics`? AFAICU clear method comes
from `javax.cache.management.CacheStatisticsMXBean`
This method calls GridCacheProcessor#clearStatistics(). It isn't new. I
brought other call in the tests to keep the conception of mxbean removal.
We keep them now only to support JCache spec. I suggest not to use JCache
mxbean interfaces any more even in the tests. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
