sashapolo commented on code in PR #1559:
URL: https://github.com/apache/ignite-3/pull/1559#discussion_r1083499305
##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/mv/AbstractPageMemoryMvPartitionStorage.java:
##########
@@ -1018,9 +1016,6 @@ protected List<AutoCloseable> getResourcesToClose() {
hashIndexes.values().forEach(index -> resources.add(index::close));
sortedIndexes.values().forEach(index -> resources.add(index::close));
- resources.add(hashIndexes::clear);
Review Comment:
Why did you remove this code?
##########
modules/storage-page-memory/src/test/java/org/apache/ignite/internal/storage/pagememory/VolatilePageMemoryMvTableStorageTest.java:
##########
@@ -57,12 +70,15 @@ void setUp(
"mock.tables.foo{ partitions = 512, dataStorage.name = " +
VolatilePageMemoryStorageEngine.ENGINE_NAME + "}"
)
TablesConfiguration tablesConfig
- ) {
+ ) throws Exception {
var ioRegistry = new PageIoRegistry();
ioRegistry.loadFromServiceLoader();
initialize(new VolatilePageMemoryStorageEngine("node", engineConfig,
ioRegistry, pageEvictionTracker), tablesConfig);
+
+ doAnswer(invocation -> touchedPages.incrementAndGet())
Review Comment:
Please leave a comment what is the purpose of this mocking
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
