rpuch commented on code in PR #1559:
URL: https://github.com/apache/ignite-3/pull/1559#discussion_r1084946898
##########
modules/storage-page-memory/src/test/java/org/apache/ignite/internal/storage/pagememory/VolatilePageMemoryMvTableStorageTest.java:
##########
@@ -57,12 +70,18 @@ void setUp(
"mock.tables.foo{ partitions = 512, dataStorage.name = " +
VolatilePageMemoryStorageEngine.ENGINE_NAME + "}"
)
TablesConfiguration tablesConfig
- ) {
+ ) throws Exception {
var ioRegistry = new PageIoRegistry();
ioRegistry.loadFromServiceLoader();
initialize(new VolatilePageMemoryStorageEngine("node", engineConfig,
ioRegistry, pageEvictionTracker), tablesConfig);
+
+ // Track how many times a page was forgotten (when emptying a Data
Page). We need it to be able to poll while
+ // awaiting till a page finally gets freed (as MV and index data
destruction is async). We don't use verify()
+ // for this end because it throws an AssertionError if the expectation
is not satisfied, which is not convenient.
Review Comment:
Switched to `verify(..., timeout())`, as suggested, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
