SammyVimes commented on code in PR #1619:
URL: https://github.com/apache/ignite-3/pull/1619#discussion_r1095689884
##########
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/MvPartitionStorage.java:
##########
@@ -225,8 +225,9 @@ public interface MvPartitionStorage extends
ManuallyCloseable {
* @param lowWatermark A time threshold for the row. Rows younger then the
watermark value will not be removed.
* @return A pair of table row and row id, where a timestamp of the row is
less than or equal to {@code lowWatermark}.
* {@code null} if there's no such value.
+ * @throws StorageException If failed to poll element for vacuum.
*/
- default @Nullable TableRowAndRowId pollForVacuum(HybridTimestamp
lowWatermark) {
+ default @Nullable TableRowAndRowId pollForVacuum(HybridTimestamp
lowWatermark) throws StorageException {
Review Comment:
What about:
- `V execute() throws StorageException;`
- `<V> V runConsistently(WriteClosure<V> closure) throws StorageException`
- `void lastApplied(long lastAppliedIndex, long lastAppliedTerm) throws
StorageException`
- `ReadResult read(RowId rowId, HybridTimestamp timestamp) throws
StorageException;`
- `@Nullable TableRow addWrite(RowId rowId, @Nullable TableRow row, UUID
txId, UUID commitTableId, int commitPartitionId) throws TxIdMismatchException,
StorageException` (this one has two!)
- `@Nullable TableRow abortWrite(RowId rowId) throws StorageException`
- `void commitWrite(RowId rowId, HybridTimestamp timestamp) throws
StorageException`
- `void addWriteCommitted(RowId rowId, @Nullable TableRow row,
HybridTimestamp commitTimestamp) throws StorageException`
- `Cursor<ReadResult> scanVersions(RowId rowId) throws StorageException`
- `PartitionTimestampCursor scan(HybridTimestamp timestamp) throws
StorageException;`
- `@Nullable RowId closestRowId(RowId lowerBound) throws StorageException;`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
