tkalkirill commented on code in PR #1619:
URL: https://github.com/apache/ignite-3/pull/1619#discussion_r1095723263
##########
modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbMvPartitionStorage.java:
##########
@@ -1015,6 +1117,149 @@ public void destroyData(WriteBatch writeBatch) throws
RocksDBException {
writeBatch.deleteRange(cf, partitionStartPrefix(),
partitionEndPrefix());
}
+ @Override
+ public @Nullable TableRowAndRowId pollForVacuum(HybridTimestamp
lowWatermark) {
+ return busy(() -> {
+ WriteBatchWithIndex batch = requireWriteBatch();
+
+ try (
+ var gcUpperBound = new Slice(partitionEndPrefix());
+ ReadOptions gcOpts = new
ReadOptions().setIterateUpperBound(gcUpperBound).setTotalOrderSeek(true);
+ RocksIterator gcIt = db.newIterator(gc, gcOpts);
+ ) {
+ gcIt.seek(partitionStartPrefix());
+
+ if (invalid(gcIt)) {
+ // GC queue is empty.
+ return null;
+ }
+
+ ByteBuffer gcKey = allocateDirect(GC_KEY_SIZE);
Review Comment:
Let's use `ThreadLocal`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
