tkalkirill commented on code in PR #1673:
URL: https://github.com/apache/ignite-3/pull/1673#discussion_r1109584433
##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/mv/RowVersion.java:
##########
@@ -112,7 +124,7 @@ boolean isTombstone() {
}
static boolean isTombstone(int valueSize) {
- return valueSize == 0;
+ return valueSize <= 0;
Review Comment:
If you look at the
`org.apache.ignite.internal.storage.pagememory.mv.RowVersion#RowVersion(int,
long, org.apache.ignite.internal.hlc.HybridTimestamp, long,
java.nio.ByteBuffer)`, then if the `ByteBuffer` is `null`, then `valueSize` is
equal to `-1`, I will fix it with 0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
