tkalkirill commented on code in PR #1673:
URL: https://github.com/apache/ignite-3/pull/1673#discussion_r1109609367


##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/mv/AddWriteCommittedInvokeClosure.java:
##########
@@ -72,23 +74,42 @@ public void call(@Nullable VersionChain oldRow) throws 
IgniteInternalCheckedExce
             throw new StorageException("Write intent exists: [rowId={}, {}]", 
oldRow.rowId(), storage.createStorageInfo());
         }
 
-        long nextLink = oldRow == null ? NULL_LINK : 
oldRow.newestCommittedLink();
+        if (oldRow == null) {
+            operationType = OperationType.PUT;
+
+            RowVersion newVersion = insertCommittedRowVersion(row, 
commitTimestamp, NULL_LINK);
+
+            newRow = VersionChain.createCommitted(rowId, newVersion.link(), 
newVersion.nextLink());
+        } else {
+            RowVersion current = storage.readRowVersion(oldRow.headLink(), 
ALWAYS_LOAD_VALUE, false);

Review Comment:
   No, I do not upload data (ByteBuffer).
   Where should it be filtered?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to