sashapolo commented on code in PR #1673:
URL: https://github.com/apache/ignite-3/pull/1673#discussion_r1109790587
##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/mv/VersionChainKey.java:
##########
@@ -18,13 +18,15 @@
package org.apache.ignite.internal.storage.pagememory.mv;
import org.apache.ignite.internal.storage.RowId;
+import org.apache.ignite.internal.tostring.IgniteToStringInclude;
/**
* Search key for the {@link VersionChainTree}.
*/
public class VersionChainKey {
/** Row id. */
- private final RowId rowId;
+ @IgniteToStringInclude
+ protected final RowId rowId;
Review Comment:
I really hate protected fields, especially when they are not needed. What's
wrong with using a getter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
