tkalkirill commented on code in PR #1673:
URL: https://github.com/apache/ignite-3/pull/1673#discussion_r1111515132
##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/mv/FindRowVersion.java:
##########
@@ -58,35 +58,35 @@ class FindRowVersion implements
PageMemoryTraversal<RowVersionFilter> {
}
@Override
- public long consumePagePayload(long link, long pageAddr, DataPagePayload
payload, RowVersionFilter arg) {
- if (!rowVersionFounded) {
- long nextLink = readPartitionless(partitionId, pageAddr,
payload.offset() + RowVersion.NEXT_LINK_OFFSET);
-
- if (arg.apply(link, pageAddr + payload.offset())) {
- rowVersionFounded = true;
-
- rowLink = link;
- rowTimestamp = HybridTimestamps.readTimestamp(pageAddr,
payload.offset() + RowVersion.TIMESTAMP_OFFSET);
- rowNextLink = nextLink;
-
- if (!loadValueBytes) {
- rowValueSize = PageUtils.getInt(pageAddr, payload.offset()
+ RowVersion.VALUE_SIZE_OFFSET);
-
- return STOP_TRAVERSAL;
- } else {
- return readRowVersionValue.consumePagePayload(link,
pageAddr, payload, null);
- }
- } else {
- return nextLink;
- }
- } else {
+ public long consumePagePayload(long link, long pageAddr, DataPagePayload
payload, RowVersionFilter filter) {
+ if (rowVersionFound) {
+ return readRowVersionValue.consumePagePayload(link, pageAddr,
payload, null);
+ }
+
+ long nextLink = readPartitionless(partitionId, pageAddr,
payload.offset() + RowVersion.NEXT_LINK_OFFSET);
+
+ if (!filter.apply(link, pageAddr + payload.offset())) {
+ return nextLink;
+ }
+
+ rowVersionFound = true;
+
+ rowLink = link;
+ rowTimestamp = HybridTimestamps.readTimestamp(pageAddr,
payload.offset() + RowVersion.TIMESTAMP_OFFSET);
+ rowNextLink = nextLink;
+
+ if (loadValueBytes) {
return readRowVersionValue.consumePagePayload(link, pageAddr,
payload, null);
}
+
+ rowValueSize = PageUtils.getInt(pageAddr, payload.offset() +
RowVersion.VALUE_SIZE_OFFSET);
Review Comment:
Not quite understood, I read this field to understand whether this
**RowVersion** is a tombstone or not without copying the array of values of
this version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
