tkalkirill commented on code in PR #1673:
URL: https://github.com/apache/ignite-3/pull/1673#discussion_r1111516793
##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/mv/gc/io/GcIo.java:
##########
@@ -118,15 +131,16 @@ default int compare(long pageAddr, int idx,
GarbageCollectionRowVersion rowVersi
* @param idx Element's index.
* @param partitionId Partition id to enrich read partitionless links.
*/
- default GarbageCollectionRowVersion getRow(long pageAddr, int idx, int
partitionId) {
+ default GcRowVersion getRow(long pageAddr, int idx, int partitionId) {
int offset = offset(idx);
long rowIdMsb = getLong(pageAddr, offset + ROW_ID_MSB_OFFSET);
long rowIdLsb = getLong(pageAddr, offset + ROW_ID_LSB_OFFSET);
- return new GarbageCollectionRowVersion(
+ return new GcRowVersion(
new RowId(partitionId, rowIdMsb, rowIdLsb),
- HybridTimestamps.readTimestamp(pageAddr, offset +
ROW_TIMESTAMP_OFFSET)
+ requireNonNull(HybridTimestamps.readTimestamp(pageAddr, offset
+ ROW_TIMESTAMP_OFFSET)),
Review Comment:
I think that this is not necessary, I did it on a question from Alexander.
I'll delete this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
