korlov42 commented on code in PR #1700:
URL: https://github.com/apache/ignite-3/pull/1700#discussion_r1117026822
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/SqlQueryProcessor.java:
##########
@@ -490,22 +495,20 @@ private
List<CompletableFuture<AsyncSqlCursor<List<Object>>>> query0(
}
for (SqlNode sqlNode : nodes) {
- boolean needStartTx = SqlKind.DML.contains(sqlNode.getKind()) ||
SqlKind.QUERY.contains(sqlNode.getKind());
+ boolean isRw = SqlKind.DML.contains(sqlNode.getKind()) ||
SqlKind.QUERY.contains(sqlNode.getKind());
// Only rw transactions for now.
- InternalTransaction implicitTx = needStartTx ? txManager.begin() :
null;
+ InternalTransaction implicitTx = txManager.begin(!isRw);
Review Comment:
the comment is still correct since we start RW transaction for any query
except DDL, but I changed this place anyway to make it less ambiguous
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
