korlov42 commented on code in PR #1700:
URL: https://github.com/apache/ignite-3/pull/1700#discussion_r1117027936
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/RuntimeSortedIndexTest.java:
##########
@@ -117,7 +117,8 @@ private RuntimeSortedIndex<Object[]> generate(RelDataType
rowType, final List<In
"fake-test-node",
null,
ArrayRowHandler.INSTANCE,
- Map.of()
+ Map.of(),
+ null, null
Review Comment:
fixed
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/ModifyNode.java:
##########
@@ -67,32 +59,27 @@
private State state = State.UPDATING;
- private InternalTransaction tx;
-
/**
* Constructor.
- * TODO Documentation https://issues.apache.org/jira/browse/IGNITE-15859
*
- * @param ctx Execution context.
- * @param table Table object.
- * @param op Operation/
- * @param cols Update column list.
+ * @param ctx An execution context.
+ * @param table A table to update.
+ * @param op A type of the update operation.
+ * @param updateColumn Enumeration of columns to update if applicable.
*/
public ModifyNode(
ExecutionContext<RowT> ctx,
- InternalIgniteTable table,
+ UpdateableTable table,
TableModify.Operation op,
- List<String> cols
+ @Nullable List<String> updateColumn
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
