tkalkirill commented on code in PR #1716:
URL: https://github.com/apache/ignite-3/pull/1716#discussion_r1118126375
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/StorageUpdateHandler.java:
##########
@@ -81,8 +89,31 @@ public void handleUpdate(
TablePartitionId commitPartitionId,
@Nullable ByteBuffer rowBuffer,
@Nullable Consumer<RowId> onReplication
+ ) {
+ handleUpdate(txId, rowUuid, commitPartitionId, rowBuffer,
onReplication, null);
+ }
+
+ /**
+ * Handles single update.
+ *
+ * @param txId Transaction id.
+ * @param rowUuid Row UUID.
+ * @param commitPartitionId Commit partition id.
+ * @param rowBuffer Row buffer.
+ * @param onReplication Callback on replication.
+ * @param lowWatermark GC low watermark.
+ */
+ public void handleUpdate(
+ UUID txId,
+ UUID rowUuid,
+ TablePartitionId commitPartitionId,
+ @Nullable ByteBuffer rowBuffer,
+ @Nullable Consumer<RowId> onReplication,
+ @Nullable HybridTimestamp lowWatermark
Review Comment:
You need to create a ticket (and add TODO) to support this argument with
write commands or something like that.
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/StorageUpdateHandler.java:
##########
@@ -118,8 +149,29 @@ public void handleUpdateAll(
Map<UUID, ByteBuffer> rowsToUpdate,
TablePartitionId commitPartitionId,
@Nullable Consumer<Collection<RowId>> onReplication
+ ) {
+ handleUpdateAll(txId, rowsToUpdate, commitPartitionId, onReplication,
null);
+ }
+
+ /**
+ * Handle multiple updates.
+ *
+ * @param txId Transaction id.
+ * @param rowsToUpdate Collection of rows to update.
+ * @param commitPartitionId Commit partition id.
+ * @param onReplication On replication callback.
+ * @param lowWatermark GC low watermark.
+ */
+ public void handleUpdateAll(
+ UUID txId,
+ Map<UUID, ByteBuffer> rowsToUpdate,
+ TablePartitionId commitPartitionId,
+ @Nullable Consumer<Collection<RowId>> onReplication,
+ @Nullable HybridTimestamp lowWatermark
Review Comment:
You need to create a ticket (and add TODO) to support this argument with
write commands or something like that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
