SammyVimes commented on code in PR #1716:
URL: https://github.com/apache/ignite-3/pull/1716#discussion_r1118346872
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/StorageUpdateHandler.java:
##########
@@ -150,6 +202,25 @@ public void handleUpdateAll(
});
}
+ private void executeBatchGc(@Nullable HybridTimestamp newLwm) {
+ if (newLwm != null) {
+ HybridTimestamp curLwm = lastRecordedLwm.updateAndGet(prevLwm -> {
+ if (prevLwm == null) {
+ return newLwm;
+ }
+
+ return newLwm.compareTo(prevLwm) > 0 ? newLwm : prevLwm;
+ });
+
+ if (curLwm == newLwm) {
Review Comment:
We can't do a single CAS here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
