ibessonov commented on code in PR #1720:
URL: https://github.com/apache/ignite-3/pull/1720#discussion_r1122684038
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -1108,14 +1082,12 @@ private void cleanUpTablesResources(Map<UUID,
TableImpl> tables) {
table.internalTable().txStateStorage(),
table.internalTable()
);
- } catch (Exception e) {
- if (!exception.compareAndSet(null, e)) {
- exception.get().addSuppressed(e);
- }
+ } catch (Throwable t) {
+ handleExceptionOnCleanUpTablesResources(t, throwable,
nodeStoppingEx);
}
- if (exception.get() != null) {
- LOG.info("Unable to stop table [name={}, tableId={}]",
exception.get(), table.name(), table.tableId());
+ if (throwable.get() != null) {
+ LOG.info("Unable to stop table [name={}, tableId={}]",
throwable.get(), table.name(), table.tableId());
Review Comment:
Info? This must be `error`
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -457,12 +455,12 @@ public TableManager(
stableAssignmentsRebalanceListener =
createStableAssignmentsRebalanceListener();
assignmentsSwitchRebalanceListener =
createAssignmentsSwitchRebalanceListener();
+
+ mvGc = new MvGc(nodeName, tablesCfg.gcThreads().value());
Review Comment:
Please never read configuration in the constructor of the component, it's
not yet initialized.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
